How to give YOU (prado community) some class files ?

[marcosanobre]

Hi all.

I am need to working with Oracle from ActiveRecord classes.

In the lack of this resource I decided to write the necessary classes for this.

I have re-wrote this files:

TOracleCommandBuilder
TOracleTableInfo
TOracleMetaData
TOracleTableColumn

and have modifyed TDbMetaData.php to include :

Code:

case 'oci':
Prado::using('System.Data.Common.Oracle.TOracleMetaData');
return new TOracleMetaData($conn);

(see the new Oracle directory at System.Data.Common)


and I am needing to share them with the community.

How can I upload this files to here ?

TIA,

MN

[jasrags]

For now you could just attach the files to your post. or post them in the wiki

[DaMule]

Hi marcosanobre,
   First off thanks for you effort in generosity and making this available to the community.

To get the ball rolling you can care a thread in the components repository board of this forum. That will get the code in the hands of the developers right away.

Then you can submit a ticket to http://trac.pradosoft.com/prado (login with your forum username and password) with your new code attached. Then it will be considered to inclusion in to the core code.

I don't know if the core developers have access to Oracle maybe that's something your could offer to help provide for them.

[Qiang]

marcosanobre , thank you for your contribution.

Yes, please create a ticket on our trac system and attach your code there. I will include them into SVN later. Thanks!

[tof06]

Hello Marcos,

I've added almost as-is your code in the framework. I just did some minor cleanup. Thanks for this work !
I didn't have access to Oracle Database, so, I can't test your code. I think Wei will review it in depth when he came back.

I closed the ticket you created, but, what was the problem with prado-cli ? Is there any error messages ?

I had an old install of Oracle (7 or 8, something like that)... Maybe I could power on this old server to see if Mr. Scott Tiger is still there !

Thanks again.

Tof.

[marcosanobre]

Ok boys, I have maded the classroom.

So, with my poor hability with track system, I thing that I did some erros in deal with it.

a) Version: I dev this classes for using in prado v3.1;
b) the ticket isn't in my space or signature; I am having dificulties in find it to edit/continue the work;

I am needing some help in:
a) testing Oracle AR with others versions rather than Oracle v10.g;
b) using prado-cli to create AR classes;

TIA.

ps: I will post another note with prado-cli problem.

MN.

[Fuse]

Here is a fix for paging support with active records. ( works for me)
( before the where parameters were deleted in the special query)

[Qiang]

Thank you very much! I will apply your patch!

[Zsolt]

Hm, this Oracle class might need some optimization.

Just for example, TOracleCommandBuilder.php has an applyLimitOffset function, which contains 30-40 lines of code, with unneccessary calls.

In my Oracle class it is:

Code:

public function applyLimitOffset($sql, $limit=-1, $offset=-1)
{
if($limit>-1 && $offset>-1)
$sql='select * from (select t.*,rownum as rn from ('.$sql.') t where rownum<='.($offset+$limit).') t where rn>'.$offset;
return $sql;
}